Re: [RFC/PATCH] packfile: use extra variable to clarify code in use_pack()

2019-03-12 Thread Ramsay Jones
On 12/03/2019 20:26, Jeff King wrote: > On Tue, Mar 12, 2019 at 05:39:13PM +, Ramsay Jones wrote: > >> On 12/03/2019 16:55, Ramsay Jones wrote: >>> From: Jeff King >>> >>> Signed-off-by: Ramsay Jones > > Could definitely use a commit message. I think it's something like: > > We use th

Re: [RFC/PATCH] packfile: use extra variable to clarify code in use_pack()

2019-03-12 Thread Jeff King
On Tue, Mar 12, 2019 at 05:39:13PM +, Ramsay Jones wrote: > On 12/03/2019 16:55, Ramsay Jones wrote: > > From: Jeff King > > > > Signed-off-by: Ramsay Jones Could definitely use a commit message. I think it's something like: We use the "offset" variable for two purposes. It's the offset

Re: [RFC/PATCH] packfile: use extra variable to clarify code in use_pack()

2019-03-12 Thread Ramsay Jones
On 12/03/2019 16:55, Ramsay Jones wrote: > From: Jeff King > > Signed-off-by: Ramsay Jones > --- > > Hi Jeff, > > I recently tried (yet again) to tidy up some old branches. When I get > around to doing a 'git gc; git fsck' I always take a quick look at > the 'dangling' commits, just before

[RFC/PATCH] packfile: use extra variable to clarify code in use_pack()

2019-03-12 Thread Ramsay Jones
From: Jeff King Signed-off-by: Ramsay Jones --- Hi Jeff, I recently tried (yet again) to tidy up some old branches. When I get around to doing a 'git gc; git fsck' I always take a quick look at the 'dangling' commits, just before a 'git gc --prune=now'. I had no recollection of this commit, f