Re: [RFC/PATCH] notes-util.c: replace git_config with git_config_get_string

2014-07-01 Thread Matthieu Moy
Tanay Abhra writes: > On 6/30/2014 7:04 PM, Karsten Blees wrote: >> Am 29.06.2014 13:01, schrieb Eric Sunshine: >>> On Thu, Jun 26, 2014 at 4:19 AM, Tanay Abhra wrote: On 6/25/2014 1:24 PM, Eric Sunshine wrote: > On Mon, Jun 23, 2014 at 6:41 AM, Tanay Abhra wrote: >> Use git_config

Re: [RFC/PATCH] notes-util.c: replace git_config with git_config_get_string

2014-06-30 Thread Junio C Hamano
Karsten Blees writes: > Which may not be too harmful in some cases, but if a user changes: > > gc.pruneexpire=4.weeks.ago > > to > > gc.pruneexpire=4.monhts.ago > > (note the typo), the next git-gc will warn the user and then happily throw > away data that the user intended to keep (default is

Re: [RFC/PATCH] notes-util.c: replace git_config with git_config_get_string

2014-06-30 Thread Tanay Abhra
On 6/30/2014 9:26 PM, Karsten Blees wrote: > Am 30.06.2014 16:39, schrieb Tanay Abhra: >> >> On 6/30/2014 7:04 PM, Karsten Blees wrote: >>> Am 29.06.2014 13:01, schrieb Eric Sunshine: On Thu, Jun 26, 2014 at 4:19 AM, Tanay Abhra wrote: > On 6/25/2014 1:24 PM, Eric Sunshine wrote: >>

Re: [RFC/PATCH] notes-util.c: replace git_config with git_config_get_string

2014-06-30 Thread Karsten Blees
Am 30.06.2014 16:39, schrieb Tanay Abhra: > > On 6/30/2014 7:04 PM, Karsten Blees wrote: >> Am 29.06.2014 13:01, schrieb Eric Sunshine: >>> On Thu, Jun 26, 2014 at 4:19 AM, Tanay Abhra wrote: On 6/25/2014 1:24 PM, Eric Sunshine wrote: > On Mon, Jun 23, 2014 at 6:41 AM, Tanay Abhra wrote

Re: [RFC/PATCH] notes-util.c: replace git_config with git_config_get_string

2014-06-30 Thread Karsten Blees
Am 30.06.2014 16:32, schrieb Eric Sunshine: > On Mon, Jun 30, 2014 at 9:34 AM, Karsten Blees > wrote: >> Am 29.06.2014 13:01, schrieb Eric Sunshine: >>> On Thu, Jun 26, 2014 at 4:19 AM, Tanay Abhra wrote: On 6/25/2014 1:24 PM, Eric Sunshine wrote: > On Mon, Jun 23, 2014 at 6:41 AM, Tana

Re: [RFC/PATCH] notes-util.c: replace git_config with git_config_get_string

2014-06-30 Thread Tanay Abhra
On 6/30/2014 7:04 PM, Karsten Blees wrote: > Am 29.06.2014 13:01, schrieb Eric Sunshine: >> On Thu, Jun 26, 2014 at 4:19 AM, Tanay Abhra wrote: >>> On 6/25/2014 1:24 PM, Eric Sunshine wrote: On Mon, Jun 23, 2014 at 6:41 AM, Tanay Abhra wrote: > Use git_config_get_string instead of git_c

Re: [RFC/PATCH] notes-util.c: replace git_config with git_config_get_string

2014-06-30 Thread Eric Sunshine
On Mon, Jun 30, 2014 at 9:34 AM, Karsten Blees wrote: > Am 29.06.2014 13:01, schrieb Eric Sunshine: >> On Thu, Jun 26, 2014 at 4:19 AM, Tanay Abhra wrote: >>> On 6/25/2014 1:24 PM, Eric Sunshine wrote: On Mon, Jun 23, 2014 at 6:41 AM, Tanay Abhra wrote: > Use git_config_get_string inste

Re: [RFC/PATCH] notes-util.c: replace git_config with git_config_get_string

2014-06-30 Thread Karsten Blees
Am 29.06.2014 13:01, schrieb Eric Sunshine: > On Thu, Jun 26, 2014 at 4:19 AM, Tanay Abhra wrote: >> On 6/25/2014 1:24 PM, Eric Sunshine wrote: >>> On Mon, Jun 23, 2014 at 6:41 AM, Tanay Abhra wrote: Use git_config_get_string instead of git_config to take advantage of the config hash-ta

Re: [RFC/PATCH] notes-util.c: replace git_config with git_config_get_string

2014-06-29 Thread Eric Sunshine
On Thu, Jun 26, 2014 at 4:19 AM, Tanay Abhra wrote: > On 6/25/2014 1:24 PM, Eric Sunshine wrote: >> On Mon, Jun 23, 2014 at 6:41 AM, Tanay Abhra wrote: >>> Use git_config_get_string instead of git_config to take advantage of >>> the config hash-table api which provides a cleaner control flow. >>>

Re: [RFC/PATCH] notes-util.c: replace git_config with git_config_get_string

2014-06-26 Thread Tanay Abhra
On 6/25/2014 1:24 PM, Eric Sunshine wrote: > On Mon, Jun 23, 2014 at 6:41 AM, Tanay Abhra wrote: >> Use git_config_get_string instead of git_config to take advantage of >> the config hash-table api which provides a cleaner control flow. >> >> Signed-off-by: Tanay Abhra >> --- >> notes-utils.c

Re: [RFC/PATCH] notes-util.c: replace git_config with git_config_get_string

2014-06-25 Thread Eric Sunshine
On Mon, Jun 23, 2014 at 6:41 AM, Tanay Abhra wrote: > Use git_config_get_string instead of git_config to take advantage of > the config hash-table api which provides a cleaner control flow. > > Signed-off-by: Tanay Abhra > --- > notes-utils.c | 31 +++ > 1 file change

[RFC/PATCH] notes-util.c: replace git_config with git_config_get_string

2014-06-23 Thread Tanay Abhra
Use git_config_get_string instead of git_config to take advantage of the config hash-table api which provides a cleaner control flow. Signed-off-by: Tanay Abhra --- notes-utils.c | 31 +++ 1 file changed, 15 insertions(+), 16 deletions(-) diff --git a/notes-utils.c b