Re: [RFC/PATCH] lockfile: improve error message when lockfile exists

2016-02-28 Thread Matthieu Moy
Moritz Neeb writes: > On 02/28/2016 09:11 PM, Matthieu Moy wrote: > >> This patch was written after seen one more time a student panicked >> because he had a "git commit" backgrounded. > > I think git commit is almost the only case where this would happen. Right. It's not the only case when Git

Re: [RFC/PATCH] lockfile: improve error message when lockfile exists

2016-02-28 Thread Duy Nguyen
On Mon, Feb 29, 2016 at 3:11 AM, Matthieu Moy wrote: > diff --git a/lockfile.c b/lockfile.c > index 80d056d..a7d6175 100644 > --- a/lockfile.c > +++ b/lockfile.c > @@ -150,9 +150,11 @@ void unable_to_lock_message(const char *path, int err, > struct strbuf *buf) > { > if (err == EEXIST) {

Re: [RFC/PATCH] lockfile: improve error message when lockfile exists

2016-02-28 Thread Moritz Neeb
On 02/28/2016 09:11 PM, Matthieu Moy wrote: > A common mistake leading a user to see this message is to launch "git > commit", let the editor open (and forget about it), and try again to > commit. > > The previous message was going too quickly to "a git process crashed" > and to the advice "remove

[RFC/PATCH] lockfile: improve error message when lockfile exists

2016-02-28 Thread Matthieu Moy
A common mistake leading a user to see this message is to launch "git commit", let the editor open (and forget about it), and try again to commit. The previous message was going too quickly to "a git process crashed" and to the advice "remove the file manually". This patch modifies the message in