Re: [RFC/PATCH] imap-send.c: replace git_config with git_config_get_string

2014-06-26 Thread Karsten Blees
Am 26.06.2014 18:50, schrieb Matthieu Moy: > Tanay Abhra writes: > >> +if (!git_config_get_string("imap.user", &value)) >> +server.user = xstrdup(value); >> +if (!git_config_get_string("imap.pass", &value)) >> +server.pass = xstrdup(value); >> +if (!git_config_

Re: [RFC/PATCH] imap-send.c: replace git_config with git_config_get_string

2014-06-26 Thread Matthieu Moy
Tanay Abhra writes: > + if (!git_config_get_string("imap.user", &value)) > + server.user = xstrdup(value); > + if (!git_config_get_string("imap.pass", &value)) > + server.pass = xstrdup(value); > + if (!git_config_get_string("imap.port", &value)) > +

Re: [RFC/PATCH] imap-send.c: replace git_config with git_config_get_string

2014-06-26 Thread Tanay Abhra
On 6/25/2014 12:39 PM, Eric Sunshine wrote: > On Mon, Jun 23, 2014 at 6:41 AM, Tanay Abhra wrote: >> Use git_config_get_string instead of git_config to take advantage of >> the config hash-table api which provides a cleaner control flow. > > You may want to mention as a side-note the slight beh

Re: [RFC/PATCH] imap-send.c: replace git_config with git_config_get_string

2014-06-25 Thread Eric Sunshine
On Mon, Jun 23, 2014 at 6:41 AM, Tanay Abhra wrote: > Use git_config_get_string instead of git_config to take advantage of > the config hash-table api which provides a cleaner control flow. You may want to mention as a side-note the slight behavior change introduced by this patch. The original co

[RFC/PATCH] imap-send.c: replace git_config with git_config_get_string

2014-06-23 Thread Tanay Abhra
Use git_config_get_string instead of git_config to take advantage of the config hash-table api which provides a cleaner control flow. Signed-off-by: Tanay Abhra --- imap-send.c | 68 ++--- 1 file changed, 29 insertions(+), 39 deletions(-)