Re: [RFC/PATCH] format-patch: introduce branch.*.forkedFrom

2014-01-07 Thread Ramkumar Ramachandra
Jeff King wrote: > I definitely respect the desire to reuse the existing tooling we have > for @{u}. At the same time, I think you are warping the meaning of > @{u} somewhat. It is _not_ your upstream here, but rather another > version of the branch that has useful changes in it. That might be > sp

Re: [RFC/PATCH] format-patch: introduce branch.*.forkedFrom

2014-01-07 Thread Jeff King
On Wed, Jan 08, 2014 at 02:32:10AM +0530, Ramkumar Ramachandra wrote: > > we should leave @{upstream} as (1), and add a new option to represent > > (2). Not the other way around. > > I have a local branch 'forkedfrom' that has two "sources": 'master' > and 'ram/forkedfrom'. 'ram/forkedfrom' isn't

Re: [RFC/PATCH] format-patch: introduce branch.*.forkedFrom

2014-01-07 Thread Ramkumar Ramachandra
Jeff King wrote: > I have not carefully read some of the later bits of the discussion from > last night / this morning, so maybe I am missing something, but this > seems backwards to me from what Junio and I were discussing earlier. > > The point was that the meaning of "@{upstream}" (and "branch.*

Re: [RFC/PATCH] format-patch: introduce branch.*.forkedFrom

2014-01-07 Thread Junio C Hamano
Jeff King writes: > The point was that the meaning of "@{upstream}" (and "branch.*.merge") > is _already_ "forked-from", and "push -u" and "push.default=upstream" > are the odd men out. If we are going to add an option to distinguish the > two branch relationships: > > 1. Where you forked from

Re: [RFC/PATCH] format-patch: introduce branch.*.forkedFrom

2014-01-07 Thread Junio C Hamano
Ramkumar Ramachandra writes: > Junio C Hamano wrote: >> I do not mind allowing laziness by defaulting to something, but I am >> not enthused by an approach that adds the new variable whose value >> is questionable. The description does not justify at all why >> @{upstream} is not a good default

Re: [RFC/PATCH] format-patch: introduce branch.*.forkedFrom

2014-01-07 Thread Ramkumar Ramachandra
Junio C Hamano wrote: > I do not mind allowing laziness by defaulting to something, but I am > not enthused by an approach that adds the new variable whose value > is questionable. The description does not justify at all why > @{upstream} is not a good default (unless the workflow is screwed up >

Re: [RFC/PATCH] format-patch: introduce branch.*.forkedFrom

2014-01-07 Thread Jeff King
On Wed, Jan 08, 2014 at 02:00:44AM +0530, Ramkumar Ramachandra wrote: > On Wed, Jan 8, 2014 at 1:59 AM, Ramkumar Ramachandra > wrote: > > A very common workflow for preparing patches involves working off a > > topic branch and generating patches against 'master' to send off to the > > maintainer

Re: [RFC/PATCH] format-patch: introduce branch.*.forkedFrom

2014-01-07 Thread Junio C Hamano
Ramkumar Ramachandra writes: > A very common workflow for preparing patches involves working off a > topic branch and generating patches against 'master' to send off to the > maintainer. However, a plain > > $ git format-patch -o outgoing > > is a no-op on a topic branch, and the user has to re

Re: [RFC/PATCH] format-patch: introduce branch.*.forkedFrom

2014-01-07 Thread Ramkumar Ramachandra
[Fixed typo in Junio's address] On Wed, Jan 8, 2014 at 1:59 AM, Ramkumar Ramachandra wrote: > A very common workflow for preparing patches involves working off a > topic branch and generating patches against 'master' to send off to the > maintainer. However, a plain > > $ git format-patch -o ou

[RFC/PATCH] format-patch: introduce branch.*.forkedFrom

2014-01-07 Thread Ramkumar Ramachandra
A very common workflow for preparing patches involves working off a topic branch and generating patches against 'master' to send off to the maintainer. However, a plain $ git format-patch -o outgoing is a no-op on a topic branch, and the user has to remember to specify 'master' explicitly every