Re: [RFC/PATCH] bisect--helper: `bisect_clean_state` shell function in C

2016-05-30 Thread Pranit Bauva
Hey Michael, On Tue, May 31, 2016 at 9:55 AM, Michael Haggerty wrote: > On 05/30/2016 08:21 PM, Pranit Bauva wrote: >> Reimplement `bisect_clean_state` shell function in C and add a >> `bisect-clean-state` subcommand to `git bisect--helper` to call it from >> git-bisect.sh . >> >> Using `bisect_c

Re: [RFC/PATCH] bisect--helper: `bisect_clean_state` shell function in C

2016-05-30 Thread Pranit Bauva
Hey Christian, On Tue, May 31, 2016 at 3:18 AM, Christian Couder wrote: > On Mon, May 30, 2016 at 8:21 PM, Pranit Bauva wrote: >> --- >> This patch contains a bug. I have tried to identify the bug and I suppose it >> exists in do_for_each_entry_in_dir(). I have reproduced the debugging session >

Re: [RFC/PATCH] bisect--helper: `bisect_clean_state` shell function in C

2016-05-30 Thread Michael Haggerty
On 05/30/2016 08:21 PM, Pranit Bauva wrote: > Reimplement `bisect_clean_state` shell function in C and add a > `bisect-clean-state` subcommand to `git bisect--helper` to call it from > git-bisect.sh . > > Using `bisect_clean_state` subcommand is a measure to port shell > function to C so as to use

Re: [RFC/PATCH] bisect--helper: `bisect_clean_state` shell function in C

2016-05-30 Thread Christian Couder
On Mon, May 30, 2016 at 8:21 PM, Pranit Bauva wrote: > --- > This patch contains a bug. I have tried to identify the bug and I suppose it > exists in do_for_each_entry_in_dir(). I have reproduced the debugging session > at this link[1]. I have seen that some patches in mailing list regarding > ite

[RFC/PATCH] bisect--helper: `bisect_clean_state` shell function in C

2016-05-30 Thread Pranit Bauva
Reimplement `bisect_clean_state` shell function in C and add a `bisect-clean-state` subcommand to `git bisect--helper` to call it from git-bisect.sh . Using `bisect_clean_state` subcommand is a measure to port shell function to C so as to use the existing test suite. As more functions are ported,