Re: [RFC/PATCH] attr: Document a new possible thread safe API

2016-10-05 Thread Junio C Hamano
Stefan Beller writes: > I think so, instead of resending the documentation, maybe the header > file shows that we're on the same page, I converted everything except > attr.c to follow this header attr.h: OK. The function signature of git_check_attr() looks suspect (it does not match the "typica

Re: [RFC/PATCH] attr: Document a new possible thread safe API

2016-10-05 Thread Stefan Beller
On Wed, Oct 5, 2016 at 10:00 AM, Junio C Hamano wrote: > Stefan Beller writes: > >> I thought about that, but as I concluded that the get_all_attrs doesn't need >> conversion to a threading environment, we can keep it as is. > > I agree that it is OK for get_all_attrs() to use its own way to ask

Re: [RFC/PATCH] attr: Document a new possible thread safe API

2016-10-05 Thread Junio C Hamano
Stefan Beller writes: > I thought about that, but as I concluded that the get_all_attrs doesn't need > conversion to a threading environment, we can keep it as is. I agree that it is OK for get_all_attrs() to use its own way to ask a question and receive an answer to it, that is different from h

Re: [RFC/PATCH] attr: Document a new possible thread safe API

2016-10-04 Thread Stefan Beller
On Tue, Oct 4, 2016 at 4:13 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> diff --git a/Documentation/technical/api-gitattributes.txt >> b/Documentation/technical/api-gitattributes.txt >> index 92fc32a..940617e 100644 >> --- a/Documentation/technical/api-gitattributes.txt >> +++ b/Docume

Re: [RFC/PATCH] attr: Document a new possible thread safe API

2016-10-04 Thread Junio C Hamano
Stefan Beller writes: > diff --git a/Documentation/technical/api-gitattributes.txt > b/Documentation/technical/api-gitattributes.txt > index 92fc32a..940617e 100644 > --- a/Documentation/technical/api-gitattributes.txt > +++ b/Documentation/technical/api-gitattributes.txt > @@ -59,7 +59,10 @@ Qu

[RFC/PATCH] attr: Document a new possible thread safe API

2016-10-04 Thread Stefan Beller
This is what we want to see at the end of the refactoring session to enable the attr subsystem to be thread safe. Signed-off-by: Stefan Beller --- Junio wrote: >> So how would we go about git_all_attrs then? > > I think you arrived the same conclusion, but ... I think the changes as propose