Re: [RFC/GSoC] Proposal: Make git-pull and git-am builtins

2015-03-25 Thread Paul Tan
On Thu, Mar 26, 2015 at 1:54 AM, Junio C Hamano wrote: > Paul Tan writes: > >> I think it's still good to have the ideal in mind though (and whoops I >> forgot to put in the word "ideal" in the text). > > Using or not using fork is merely one of the trade-offs we can make. > > "If all other thing

Re: [RFC/GSoC] Proposal: Make git-pull and git-am builtins

2015-03-25 Thread Sebastian Schuberth
On 24.03.2015 17:37, Paul Tan wrote: I'm applying for git in the Google Summer of Code this year. For my project, I propose to rewrite git-pull.sh and git-am.sh into fast optimized C builtins. I've already hacked up a prototype of a builtin git-pull in [1], and it showed a promising 8x improveme

Re: [RFC/GSoC] Proposal: Make git-pull and git-am builtins

2015-03-25 Thread Junio C Hamano
Paul Tan writes: > I think it's still good to have the ideal in mind though (and whoops I > forgot to put in the word "ideal" in the text). Using or not using fork is merely one of the trade-offs we can make. "If all other things are equal, no fork is better than a fork" is a meaningless statem

Re: [RFC/GSoC] Proposal: Make git-pull and git-am builtins

2015-03-24 Thread Paul Tan
Hi, On Wed, Mar 25, 2015 at 2:37 AM, Junio C Hamano wrote: > Paul Tan writes: > >> ..., I propose the following requirements for the rewritten code: >> >> 1. No spawning of external git processes. This is to support systems with >> high >>``fork()`` or process creation overhead, and to redu

Re: [RFC/GSoC] Proposal: Make git-pull and git-am builtins

2015-03-24 Thread Junio C Hamano
Paul Tan writes: > ..., I propose the following requirements for the rewritten code: > > 1. No spawning of external git processes. This is to support systems with high >``fork()`` or process creation overhead, and to reduce redundant IO by >taking advantage of the internal object, index a

Re: [RFC/GSoC] Proposal: Make git-pull and git-am builtins

2015-03-24 Thread Matthieu Moy
Paul Tan writes: > On Tue, Mar 24, 2015 at 6:19 PM, Matthieu Moy > wrote: > >> About the timeline: I'd avoid too much parallelism. Usually, it's best >> to try to send a first patch to the mailing list as soon as possible, >> hence focus on one point first (I'd do that with pull, since that's th

Re: [RFC/GSoC] Proposal: Make git-pull and git-am builtins

2015-03-24 Thread Paul Tan
On Tue, Mar 24, 2015 at 6:19 PM, Matthieu Moy wrote: > A few minor details: > > "on operating systems with poor file system performance (i.e. Windows)" > => that's not only windows, I also commonly use a slow filesystem on > Linux, just because it's NFS. Mentionning other cases of poor filesystem

[RFC/GSoC] Proposal: Make git-pull and git-am builtins

2015-03-24 Thread Paul Tan
Hi all, I'm applying for git in the Google Summer of Code this year. For my project, I propose to rewrite git-pull.sh and git-am.sh into fast optimized C builtins. I've already hacked up a prototype of a builtin git-pull in [1], and it showed a promising 8x improvement in execution time on Windows