Re: [Qemu-devel] [PATCH v3 0/7] cpu: add device_add foo-x86_64-cpu support

2015-02-06 Thread Jeff King
On Thu, Feb 05, 2015 at 12:17:15PM -0800, Junio C Hamano wrote: > > Would "length() > 1" be enough[1]? Or are people really typing "yes" and > > not just "y"? > > > > I cannot imagine a charset name that is smaller than two characters. It > > may be that there are none smaller than 4, and we could

Re: [Qemu-devel] [PATCH v3 0/7] cpu: add device_add foo-x86_64-cpu support

2015-02-05 Thread Junio C Hamano
Jeff King writes: > On Thu, Feb 05, 2015 at 11:29:07AM -0800, Junio C Hamano wrote: > >> Eric Blake writes: >> >> > On 02/05/2015 04:49 AM, Stefan Hajnoczi wrote: >> >> On Wed, Jan 14, 2015 at 03:27:23PM +0800, Zhu Guihua wrote: >> >>> This series is based on the previous patchset from Chen Fan

Re: [Qemu-devel] [PATCH v3 0/7] cpu: add device_add foo-x86_64-cpu support

2015-02-05 Thread Jeff King
On Thu, Feb 05, 2015 at 11:29:07AM -0800, Junio C Hamano wrote: > Eric Blake writes: > > > On 02/05/2015 04:49 AM, Stefan Hajnoczi wrote: > >> On Wed, Jan 14, 2015 at 03:27:23PM +0800, Zhu Guihua wrote: > >>> This series is based on the previous patchset from Chen Fan: > >>> https://lists.nongnu

Re: [Qemu-devel] [PATCH v3 0/7] cpu: add device_add foo-x86_64-cpu support

2015-02-05 Thread Junio C Hamano
Eric Blake writes: > On 02/05/2015 04:49 AM, Stefan Hajnoczi wrote: >> On Wed, Jan 14, 2015 at 03:27:23PM +0800, Zhu Guihua wrote: >>> This series is based on the previous patchset from Chen Fan: >>> https://lists.nongnu.org/archive/html/qemu-devel/2014-05/msg02360.html >> >> This email has an i

Re: [Qemu-devel] [PATCH v3 0/7] cpu: add device_add foo-x86_64-cpu support

2015-02-05 Thread Eric Blake
[adding git list to cc] On 02/05/2015 04:49 AM, Stefan Hajnoczi wrote: > On Wed, Jan 14, 2015 at 03:27:23PM +0800, Zhu Guihua wrote: >> This series is based on the previous patchset from Chen Fan: >> https://lists.nongnu.org/archive/html/qemu-devel/2014-05/msg02360.html > > This email has an inva