RE: [Proposed Fix] daemon.c: not initializing revents

2019-02-12 Thread Randall S. Becker
On February 11, 2019 21:59, Junio C Hamano wrote: > "Randall S. Becker" writes: > > >> In any case, no matter what POSIX says, if clearing .revents before > > calling > >> poll() helps on platforms in the real world, the patch is worth > >> taking as > > a fix, I > >> would think. > > > > That's

Re: [Proposed Fix] daemon.c: not initializing revents

2019-02-11 Thread Junio C Hamano
"Randall S. Becker" writes: >> In any case, no matter what POSIX says, if clearing .revents before > calling >> poll() helps on platforms in the real world, the patch is worth taking as > a fix, I >> would think. > > That's what my intent was - my explanations are suffering from a little > work-i

RE: [Proposed Fix] daemon.c: not initializing revents

2019-02-11 Thread Randall S. Becker
On February 11, 2019 15:57, Junio C Hamano wrote: > "Randall S. Becker" writes: > > > Hi All, > > > > I found this while trying to track down a hang in t5562 - this isn't > > the fix, but here it is something that could be considered a > > code-inspection. If there have been random unexplained ha

Re: [Proposed Fix] daemon.c: not initializing revents

2019-02-11 Thread Junio C Hamano
"Randall S. Becker" writes: > Hi All, > > I found this while trying to track down a hang in t5562 - this isn't the > fix, but here it is something that could be considered a code-inspection. If > there have been random unexplained hangs when git runs as a daemon, this > might be the cause. > > Ac

[Proposed Fix] daemon.c: not initializing revents

2019-02-09 Thread Randall S. Becker
Hi All, I found this while trying to track down a hang in t5562 - this isn't the fix, but here it is something that could be considered a code-inspection. If there have been random unexplained hangs when git runs as a daemon, this might be the cause. According to many systems (other than Linux),