RE: [Patch v1 2/3] t5318: replace use of /dev/zero with generate_zero_bytes

2019-02-13 Thread Randall S. Becker
On February 13, 2019 16:01, Junio C Hamano wrote: > "Randall S. Becker" writes: > > > My second attempt was to create the generate_zero_bytes function to > > replace exactly what the second dd was doing but not user /dev/zero. > > Yes, and I think the patch does that ;-) It was just the origina

Re: [Patch v1 2/3] t5318: replace use of /dev/zero with generate_zero_bytes

2019-02-13 Thread Junio C Hamano
"Randall S. Becker" writes: > My second attempt was to create the generate_zero_bytes function to replace > exactly what the second dd was doing but not user /dev/zero. Yes, and I think the patch does that ;-) It was just the original dd if=/dev/zero of=... bs=1 seek=$there count=$this_man

RE: [Patch v1 2/3] t5318: replace use of /dev/zero with generate_zero_bytes

2019-02-13 Thread Randall S. Becker
> -Original Message- > From: Junio C Hamano On Behalf Of Junio C Hamano > Sent: February 13, 2019 12:25 > To: Eric Sunshine > Cc: randall.s.bec...@rogers.com; Git List ; Randall S. > Becker > Subject: Re: [Patch v1 2/3] t5318: replace use of /dev/zero with

Re: [Patch v1 2/3] t5318: replace use of /dev/zero with generate_zero_bytes

2019-02-13 Thread Junio C Hamano
Junio C Hamano writes: > Eric Sunshine writes: > >> On Sat, Feb 9, 2019 at 2:00 PM wrote: >>> This change removes the dependency on /dev/zero with generate_zero_bytes >>> appending NUL values to blocks generating wrong signatures for test cases. >> >> This commit message says what the patch doe

Re: [Patch v1 2/3] t5318: replace use of /dev/zero with generate_zero_bytes

2019-02-12 Thread Junio C Hamano
Eric Sunshine writes: > On Sat, Feb 9, 2019 at 2:00 PM wrote: >> This change removes the dependency on /dev/zero with generate_zero_bytes >> appending NUL values to blocks generating wrong signatures for test cases. > > This commit message says what the patch does but not _why_. At > minimum, it

Re: [Patch v1 2/3] t5318: replace use of /dev/zero with generate_zero_bytes

2019-02-09 Thread Eric Sunshine
On Sat, Feb 9, 2019 at 2:00 PM wrote: > This change removes the dependency on /dev/zero with generate_zero_bytes > appending NUL values to blocks generating wrong signatures for test cases. This commit message says what the patch does but not _why_. At minimum, it should explain that /dev/zero is

[Patch v1 2/3] t5318: replace use of /dev/zero with generate_zero_bytes

2019-02-09 Thread randall . s . becker
From: "Randall S. Becker" This change removes the dependency on /dev/zero with generate_zero_bytes appending NUL values to blocks generating wrong signatures for test cases. Signed-off-by: Randall S. Becker --- t/t5318-commit-graph.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff