RE: [Patch v1 1/3] test-lib-functions.sh: add generate_zero_bytes function

2019-02-11 Thread randall.s.becker
On February 11, 2019 20:18, Eric Sunshine wrote: > On Mon, Feb 11, 2019 at 7:37 PM Jeff King wrote: > > On Sat, Feb 09, 2019 at 09:05:04PM -0500, Eric Sunshine wrote: > > > On Sat, Feb 9, 2019 at 1:59 PM wrote: > > > > +generate_zero_bytes () { > > > > + perl -e 'if ($ARGV[0] == "infinity")

Re: [Patch v1 1/3] test-lib-functions.sh: add generate_zero_bytes function

2019-02-11 Thread Eric Sunshine
On Mon, Feb 11, 2019 at 7:37 PM Jeff King wrote: > On Sat, Feb 09, 2019 at 09:05:04PM -0500, Eric Sunshine wrote: > > On Sat, Feb 9, 2019 at 1:59 PM wrote: > > > +generate_zero_bytes () { > > > + perl -e 'if ($ARGV[0] == "infinity") { > > > > s/perl/"$PERL_PATH"/ > > This shouldn't be neces

Re: [Patch v1 1/3] test-lib-functions.sh: add generate_zero_bytes function

2019-02-11 Thread Jeff King
On Sat, Feb 09, 2019 at 09:05:04PM -0500, Eric Sunshine wrote: > On Sat, Feb 9, 2019 at 1:59 PM wrote: > > t5318 and t5562 used /dev/zero, which is not portable. This function > > provides both a fixed block of NUL bytes and an infinite stream of NULs. > > > > Signed-off-by: Randall S. Becker >

RE: [Patch v1 1/3] test-lib-functions.sh: add generate_zero_bytes function

2019-02-10 Thread Randall S. Becker
On February 9, 2019 21:05, Eric Sunshine wrote: > On Sat, Feb 9, 2019 at 1:59 PM wrote: > > t5318 and t5562 used /dev/zero, which is not portable. This function > > provides both a fixed block of NUL bytes and an infinite stream of NULs. > > > > Signed-off-by: Randall S. Becker > > --- > > diff -

Re: [Patch v1 1/3] test-lib-functions.sh: add generate_zero_bytes function

2019-02-09 Thread Eric Sunshine
On Sat, Feb 9, 2019 at 1:59 PM wrote: > t5318 and t5562 used /dev/zero, which is not portable. This function > provides both a fixed block of NUL bytes and an infinite stream of NULs. > > Signed-off-by: Randall S. Becker > --- > diff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh > @@

[Patch v1 1/3] test-lib-functions.sh: add generate_zero_bytes function

2019-02-09 Thread randall . s . becker
From: "Randall S. Becker" t5318 and t5562 used /dev/zero, which is not portable. This function provides both a fixed block of NUL bytes and an infinite stream of NULs. Signed-off-by: Randall S. Becker --- t/test-lib-functions.sh | 13 + 1 file changed, 13 insertions(+) diff --git