Re: [PATCHv9 1/9] receive-pack.c: shorten the execute_commands loop over all commands

2015-01-05 Thread Stefan Beller
On Sat, Jan 3, 2015 at 1:53 AM, Duy Nguyen wrote: > On Sat, Jan 3, 2015 at 9:20 AM, Jonathan Nieder wrote: >>> - if (shallow_update && !checked_connectivity) >>> - error("BUG: run 'git fsck' for safety.\n" >>> - "If there are errors, try to remove " >>> -

Re: [PATCHv9 1/9] receive-pack.c: shorten the execute_commands loop over all commands

2015-01-03 Thread Duy Nguyen
On Sat, Jan 3, 2015 at 9:20 AM, Jonathan Nieder wrote: >> - if (shallow_update && !checked_connectivity) >> - error("BUG: run 'git fsck' for safety.\n" >> - "If there are errors, try to remove " >> - "the reported refs above"); >> + if (shall

Re: [PATCHv9 1/9] receive-pack.c: shorten the execute_commands loop over all commands

2015-01-02 Thread Jonathan Nieder
(+cc: Duy, who understands shallow push well) Hi, Stefan Beller wrote: > This commit shortens execute_commands loop over all commands by moving The commit message can be simplified by leaving out "This commit" and stating what the commit does in the imperative, focusing on what problem the commi

[PATCHv9 1/9] receive-pack.c: shorten the execute_commands loop over all commands

2014-12-30 Thread Stefan Beller
This commit shortens execute_commands loop over all commands by moving some parts of the code to extra functions. This will help us in a later patch to avoid duplicate code when the loop over all commands should be made atomic or not. No functional changes intended. Suggested-by: Eric Sunshine S