Re: [PATCHv5] clone --single: limit the fetch refspec to fetched branch

2012-09-18 Thread Junio C Hamano
Ralf Thielow writes: > IMO if a user uses "clone --single-branch --branch ", then he/she > wants to have this tag only. Why should the next "git fetch" fetching > something different? OK, I can buy that. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message t

Re: [PATCHv5] clone --single: limit the fetch refspec to fetched branch

2012-09-18 Thread Ralf Thielow
On Mon, Sep 17, 2012 at 11:39 PM, Junio C Hamano wrote: > Ralf Thielow writes: > - install correct refspec if the value of --branch is a tag (test added) >>> >>> What is the definition of "correct"? I see the documentation says >>> "--branch can also take tags and treat them like detached H

Re: [PATCHv5] clone --single: limit the fetch refspec to fetched branch

2012-09-17 Thread Junio C Hamano
Ralf Thielow writes: >>> - install correct refspec if the value of --branch is a tag (test added) >> >> What is the definition of "correct"? I see the documentation says >> "--branch can also take tags and treat them like detached HEAD", and >> even though I _think_ allowing tags was a huge mist

Re: [PATCHv5] clone --single: limit the fetch refspec to fetched branch

2012-09-17 Thread Ralf Thielow
On Mon, Sep 17, 2012 at 10:18 PM, Junio C Hamano wrote: > Ralf Thielow writes: > >> - handle --mirror option (test added) > > Handle how? I personally think erroring out is the right way to > handle it, but if we care about people who have been misusing the > combination of single and mirror, th

Re: [PATCHv5] clone --single: limit the fetch refspec to fetched branch

2012-09-17 Thread Junio C Hamano
Ralf Thielow writes: > - handle --mirror option (test added) Handle how? I personally think erroring out is the right way to handle it, but if we care about people who have been misusing the combination of single and mirror, the second best way would be to imply "mirror" and "single" combinatio

[PATCHv5] clone --single: limit the fetch refspec to fetched branch

2012-09-17 Thread Ralf Thielow
After running "git clone --single", the resulting repository has the usual default "+refs/heads/*:refs/remotes/origin/*" wildcard fetch refspec installed, which means that a subsequent "git fetch" will end up grabbing all the other branches. Update the fetch refspec to cover only the singly cloned