Re: [PATCHv4 0/6] Add missing includes and forward declares

2018-08-16 Thread Jeff King
On Thu, Aug 16, 2018 at 01:19:17AM +0100, Ramsay Jones wrote: > As a quick ("just before bedtime") exercise, I tried adding > a Makefile target to perform a similar check. The result is > given below, but I haven't had time to look too closely at > the results: The resulting patch doesn't look to

Re: [PATCHv4 0/6] Add missing includes and forward declares

2018-08-16 Thread Junio C Hamano
Ramsay Jones writes: > BTW, I happen to be on the 'pu' branch. > > I think some of the errors are due to missing compiler flags > (-I, -D, etc); which flags did you pass to the compiler? > > Well, it killed 15min. before bed! ;-) > > ATB, > Ramsay Jones It certainly does look fun. I anticipate

Re: [PATCHv4 0/6] Add missing includes and forward declares

2018-08-15 Thread Ramsay Jones
On 15/08/18 18:54, Elijah Newren wrote: > This series fixes compilation errors when using a simple test.c file that > includes git-compat-util.h and then exactly one other header (and repeating > this for different headers of git). > [snip] > 1: f7d50cef3b ! 1: e6a93208b2 Add missing include

Re: [PATCHv4 0/6] Add missing includes and forward declares

2018-08-15 Thread Jonathan Nieder
Elijah Newren wrote: > 62 files changed, 152 insertions(+), 18 deletions(-) All 6 patches in this series are Reviewed-by: Jonathan Nieder Thanks for your patient work. Pointer to previous rounds for the curious: https://public-inbox.org/git/20180811043218.31456-1-new...@gmail.com/

[PATCHv4 0/6] Add missing includes and forward declares

2018-08-15 Thread Elijah Newren
This series fixes compilation errors when using a simple test.c file that includes git-compat-util.h and then exactly one other header (and repeating this for different headers of git). Changes in this series come from Jonathan Nieder's reviews; full range-diff follows below, but in summary: -