Re: [PATCHv4] sha1_file: fix iterating loose alternate objects

2015-02-02 Thread Jeff King
On Mon, Feb 02, 2015 at 12:00:17PM -0800, Junio C Hamano wrote: > Jonathon Mah writes: > > > +test_expect_success 'prune: handle alternate object database' ' > > + test_create_repo A && > > + (cd A && > > + echo "Hello World" >file1 && > > + git add file1 && > > +

Re: [PATCHv4] sha1_file: fix iterating loose alternate objects

2015-02-02 Thread Junio C Hamano
Jonathon Mah writes: > +test_expect_success 'prune: handle alternate object database' ' > + test_create_repo A && > + (cd A && > + echo "Hello World" >file1 && > + git add file1 && > + git commit -m "Initial commit" file1) && > + git clone -

Re: [PATCHv4] sha1_file: fix iterating loose alternate objects

2015-02-02 Thread Junio C Hamano
Jeff King writes: > On Mon, Feb 02, 2015 at 10:48:12AM -0800, Jonathon Mah wrote: > >> The string in 'base' contains a path suffix to a specific object; when >> its value is used, the suffix must either be filled (as in >> stat_sha1_file, open_sha1_file, check_and_freshen_nonlocal) or cleared >>

Re: [PATCHv4] sha1_file: fix iterating loose alternate objects

2015-02-02 Thread Jeff King
On Mon, Feb 02, 2015 at 10:48:12AM -0800, Jonathon Mah wrote: > The string in 'base' contains a path suffix to a specific object; when > its value is used, the suffix must either be filled (as in > stat_sha1_file, open_sha1_file, check_and_freshen_nonlocal) or cleared > (as in prepare_packed_git)

[PATCHv4] sha1_file: fix iterating loose alternate objects

2015-02-02 Thread Jonathon Mah
The string in 'base' contains a path suffix to a specific object; when its value is used, the suffix must either be filled (as in stat_sha1_file, open_sha1_file, check_and_freshen_nonlocal) or cleared (as in prepare_packed_git) to avoid junk at the end. loose_from_alt_odb (introduced in 660c889e46