Re: [PATCHv3 5/5] git-send-email: use git credential to obtain password

2013-02-11 Thread Jeff King
On Mon, Feb 11, 2013 at 06:17:27PM +0100, Michal Nazarewicz wrote: > > I am happy to put it off until it becomes a problem, but I wonder if the > > Git::credential() interface is sufficient to express what we would want. > > It only allows two return values: true for approve, false for reject. > >

Re: [PATCHv3 5/5] git-send-email: use git credential to obtain password

2013-02-11 Thread Michal Nazarewicz
> On Mon, Feb 11, 2013 at 05:23:39PM +0100, Michal Nazarewicz wrote: >> +# TODO: Authentication may fail not because credentials were >> +# invalid but due to other reasons, in which we should not >> +# reject credentials. >> +$auth = Git::credential({ >> +'protocol' =>

Re: [PATCHv3 5/5] git-send-email: use git credential to obtain password

2013-02-11 Thread Jeff King
On Mon, Feb 11, 2013 at 05:23:39PM +0100, Michal Nazarewicz wrote: > + # TODO: Authentication may fail not because credentials were > + # invalid but due to other reasons, in which we should not > + # reject credentials. > + $auth = Git::credential({ > + 'protocol' => '

[PATCHv3 5/5] git-send-email: use git credential to obtain password

2013-02-11 Thread Michal Nazarewicz
From: Michal Nazarewicz If smtp_user is provided but smtp_pass is not, instead of prompting for password, make git-send-email use git credential command instead. Signed-off-by: Michal Nazarewicz --- Documentation/git-send-email.txt | 4 +-- git-send-email.perl | 59 ++