Re: [PATCHv3 4/5] Git.pm: add interface for git credential command

2013-02-11 Thread Jeff King
On Mon, Feb 11, 2013 at 06:14:24PM +0100, Michal Nazarewicz wrote: > > Should this return a hash reference? It seems like that is how we end up > > using and passing it elsewhere (since we have to anyway when passing it > > as a parameter). > > Admittedly I mostly just copied what git-remote-medi

Re: [PATCHv3 4/5] Git.pm: add interface for git credential command

2013-02-11 Thread Michal Nazarewicz
On Mon, Feb 11 2013, Jeff King wrote: > On Mon, Feb 11, 2013 at 05:23:38PM +0100, Michal Nazarewicz wrote: > >> +=item credential_read( FILE_HANDLE ) >> + >> +Reads credential key-value pairs from C. Reading stops at EOF >> or >> +when an empty line is encountered. Each line must be of the form

Re: [PATCHv3 4/5] Git.pm: add interface for git credential command

2013-02-11 Thread Jeff King
On Mon, Feb 11, 2013 at 05:23:38PM +0100, Michal Nazarewicz wrote: > +=item credential_read( FILE_HANDLE ) > + > +Reads credential key-value pairs from C. Reading stops at EOF > or > +when an empty line is encountered. Each line must be of the form > C > +with a non-empty key. Function return

[PATCHv3 4/5] Git.pm: add interface for git credential command

2013-02-11 Thread Michal Nazarewicz
From: Michal Nazarewicz Add a credential() function which is an interface to the git credential command. The code is heavily based on credential_* functions in . Signed-off-by: Michal Nazarewicz --- perl/Git.pm | 148 +++- 1 file changed