Re: [PATCHv3 1/2] push: change submodule default to check when submodules exist

2016-10-07 Thread Heiko Voigt
On Thu, Oct 06, 2016 at 10:20:16AM -0700, Stefan Beller wrote: > On Thu, Oct 6, 2016 at 2:23 AM, Heiko Voigt wrote: > > On Wed, Oct 05, 2016 at 03:53:25PM +0200, Heiko Voigt wrote: > >> On Tue, Oct 04, 2016 at 02:03:58PM -0700, Stefan Beller wrote: > >> > Jeff, > >> > thanks for the suggestions, b

Re: [PATCHv3 1/2] push: change submodule default to check when submodules exist

2016-10-06 Thread Stefan Beller
On Thu, Oct 6, 2016 at 2:23 AM, Heiko Voigt wrote: > On Wed, Oct 05, 2016 at 03:53:25PM +0200, Heiko Voigt wrote: >> On Tue, Oct 04, 2016 at 02:03:58PM -0700, Stefan Beller wrote: >> > Jeff, >> > thanks for the suggestions, both git_path(..) as well as checking the >> > config, >> > this seems qu

Re: [PATCHv3 1/2] push: change submodule default to check when submodules exist

2016-10-06 Thread Heiko Voigt
On Wed, Oct 05, 2016 at 03:53:25PM +0200, Heiko Voigt wrote: > On Tue, Oct 04, 2016 at 02:03:58PM -0700, Stefan Beller wrote: > > Jeff, > > thanks for the suggestions, both git_path(..) as well as checking the > > config, > > this seems quite readable to me: > > When reading the discussion I thou

Re: [PATCHv3 1/2] push: change submodule default to check when submodules exist

2016-10-05 Thread Stefan Beller
On Wed, Oct 5, 2016 at 8:47 AM, Jeff King wrote: > On Tue, Oct 04, 2016 at 02:03:58PM -0700, Stefan Beller wrote: > >> thanks for the suggestions, both git_path(..) as well as checking the config, >> this seems quite readable to me: >> >> builtin/push.c | 14 +- >> 1 file changed, 13

Re: [PATCHv3 1/2] push: change submodule default to check when submodules exist

2016-10-05 Thread Jeff King
On Tue, Oct 04, 2016 at 02:03:58PM -0700, Stefan Beller wrote: > thanks for the suggestions, both git_path(..) as well as checking the config, > this seems quite readable to me: > > builtin/push.c | 14 +- > 1 file changed, 13 insertions(+), 1 deletion(-) Yeah, this seems like a goo

Re: [PATCHv3 1/2] push: change submodule default to check when submodules exist

2016-10-05 Thread Heiko Voigt
On Tue, Oct 04, 2016 at 02:03:58PM -0700, Stefan Beller wrote: > Jeff, > thanks for the suggestions, both git_path(..) as well as checking the config, > this seems quite readable to me: When reading the discussion I thought the same: What about the "old-style" repositories. I like this one. Checki

[PATCHv3 1/2] push: change submodule default to check when submodules exist

2016-10-04 Thread Stefan Beller
When working with submodules, it is easy to forget to push the submodules. The setting 'check', which checks if any existing submodule is present on at least one remote of the submodule remotes, is designed to prevent this mistake. Flipping the default to check for submodules is safer than the cur