Re: [PATCHv3 0/5] verify-commit: verify commit signatures

2014-06-23 Thread Junio C Hamano
Jeff King writes: > On Mon, Jun 23, 2014 at 10:52:38AM -0700, Junio C Hamano wrote: > >> > The one thing that does give me pause is that we do not seem to have any >> > way of accessing mergetag signatures. We should perhaps stop and think >> > for a second about how we might expose those (and wh

Re: [PATCHv3 0/5] verify-commit: verify commit signatures

2014-06-23 Thread Jeff King
On Mon, Jun 23, 2014 at 10:52:38AM -0700, Junio C Hamano wrote: > > The one thing that does give me pause is that we do not seem to have any > > way of accessing mergetag signatures. We should perhaps stop and think > > for a second about how we might expose those (and whether it would fit > > int

Re: [PATCHv3 0/5] verify-commit: verify commit signatures

2014-06-23 Thread Junio C Hamano
Jeff King writes: > On Mon, Jun 23, 2014 at 09:05:46AM +0200, Michael J Gruber wrote: > >> This incorporates all remarks about the test coding guidelines and >> rearranging the series. >> >> Open questions: >> - There was some debate about (optionally) verifying more than what >> git-verify-{com

Re: [PATCHv3 0/5] verify-commit: verify commit signatures

2014-06-23 Thread Jeff King
On Mon, Jun 23, 2014 at 09:05:46AM +0200, Michael J Gruber wrote: > This incorporates all remarks about the test coding guidelines and > rearranging the series. > > Open questions: > - There was some debate about (optionally) verifying more than what > git-verify-{commit,tag} currently do, or goi

[PATCHv3 0/5] verify-commit: verify commit signatures

2014-06-23 Thread Michael J Gruber
This incorporates all remarks about the test coding guidelines and rearranging the series. Open questions: - There was some debate about (optionally) verifying more than what git-verify-{commit,tag} currently do, or going for a generic git-verify command. The former would require both to be change