Re: [PATCHv3 0/5] Add git-credential support to git-send-email

2013-02-11 Thread Michal Nazarewicz
On Mon, Feb 11 2013, Jeff King wrote: > Based on our discussion, I think it would just need the patch below > squashed into your 4/5 (this handles the "undef" thing, and I also fixed > a few typos in the API documentation): > @@ -1152,7 +1155,9 @@ sub credential { > if ('CODE' eq ref $op_or_

Re: [PATCHv3 0/5] Add git-credential support to git-send-email

2013-02-11 Thread Jeff King
On Mon, Feb 11, 2013 at 06:18:04PM +0100, Michal Nazarewicz wrote: > On Mon, Feb 11 2013, Jeff King wrote: > > I have two minor comments, which I'll reply inline with. But even with > > those comments, I think this would be OK to merge. > > I'll send a new patchset tomorrow with. Based on our di

Re: [PATCHv3 0/5] Add git-credential support to git-send-email

2013-02-11 Thread Michal Nazarewicz
On Mon, Feb 11 2013, Jeff King wrote: > I have two minor comments, which I'll reply inline with. But even with > those comments, I think this would be OK to merge. I'll send a new patchset tomorrow with. -- Best regards, _ _ .o. | Liege of Serenely Enl

Re: [PATCHv3 0/5] Add git-credential support to git-send-email

2013-02-11 Thread Jeff King
On Mon, Feb 11, 2013 at 05:23:34PM +0100, Michal Nazarewicz wrote: > From: Michal Nazarewicz > > The third version of the patch with changes suggested by Jeff in the > 4/5 patch. Also credential_read and credential_write are now public > functions in case someone wants to write a helper in perl

[PATCHv3 0/5] Add git-credential support to git-send-email

2013-02-11 Thread Michal Nazarewicz
From: Michal Nazarewicz The third version of the patch with changes suggested by Jeff in the 4/5 patch. Also credential_read and credential_write are now public functions in case someone wants to write a helper in perl. Michal Nazarewicz (5): Git.pm: allow command_close_bidi_pipe to be called