Re: [PATCHv3] submodule--helper: normalize funny urls

2016-10-21 Thread Stefan Beller
On Tue, Oct 18, 2016 at 7:05 PM, Junio C Hamano wrote: > Stefan Beller writes: > >>> I am not sure. Certainly we would want to make sure that the normal >>> case (i.e. no funny trailing junk) to work correctly, but we do want >>> to protect the fix from future breakage as well, no? >> >> Exactly

Re: [PATCHv3] submodule--helper: normalize funny urls

2016-10-20 Thread Junio C Hamano
Stefan Beller writes: > My thought was to fix it nevertheless, such that the url recorded as > remote.origin.url is always the first case (no l or /. at the end). > > If we were to add this fix to clone, then it may be easier to debug > submodule url schemes for users as the submodule url would t

Re: [PATCHv3] submodule--helper: normalize funny urls

2016-10-20 Thread Stefan Beller
On Thu, Oct 20, 2016 at 12:26 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> Do we actually want to fix git-clone as well? > > If I understand correctly, the point of this fix is to make it not > to matter whether the original URL the end user gives or recorded as > the remote by "git clo

Re: [PATCHv3] submodule--helper: normalize funny urls

2016-10-20 Thread Junio C Hamano
Stefan Beller writes: > Do we actually want to fix git-clone as well? If I understand correctly, the point of this fix is to make it not to matter whether the original URL the end user gives or recorded as the remote by "git clone" in the repository is any one of: $any_leading_part/path

Re: [PATCHv3] submodule--helper: normalize funny urls

2016-10-20 Thread Stefan Beller
On Tue, Oct 18, 2016 at 7:05 PM, Junio C Hamano wrote: > Stefan Beller writes: > >>> I am not sure. Certainly we would want to make sure that the normal >>> case (i.e. no funny trailing junk) to work correctly, but we do want >>> to protect the fix from future breakage as well, no? >> >> Exactly

Re: [PATCHv3] submodule--helper: normalize funny urls

2016-10-18 Thread Junio C Hamano
Stefan Beller writes: >> I am not sure. Certainly we would want to make sure that the normal >> case (i.e. no funny trailing junk) to work correctly, but we do want >> to protect the fix from future breakage as well, no? > > Exactly. So not intermediate "root" that we clone from, but adapting th

Re: [PATCHv3] submodule--helper: normalize funny urls

2016-10-18 Thread Stefan Beller
On Tue, Oct 18, 2016 at 5:56 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> The underlying issue is two fold: >> >> * in t3600 we'd need >> diff --git a/t/t3600-rm.sh b/t/t3600-rm.sh >> index d046d98..545d32f 100755 >> --- a/t/t3600-rm.sh >> +++ b/t/t3600-rm.sh >> @@ -616,7 +616,7 @@ test

Re: [PATCHv3] submodule--helper: normalize funny urls

2016-10-18 Thread Junio C Hamano
Stefan Beller writes: > The underlying issue is two fold: > > * in t3600 we'd need > diff --git a/t/t3600-rm.sh b/t/t3600-rm.sh > index d046d98..545d32f 100755 > --- a/t/t3600-rm.sh > +++ b/t/t3600-rm.sh > @@ -616,7 +616,7 @@ test_expect_success 'setup subsubmodule' ' > git submodule upda

Re: [PATCHv3] submodule--helper: normalize funny urls

2016-10-18 Thread Stefan Beller
On Tue, Oct 18, 2016 at 2:19 PM, Junio C Hamano wrote: > Junio C Hamano writes: > >> Stefan Beller writes: >> >>> The remote URL for the submodule can be specified relative >>> ... >>> v3: >>> * fixed the coding style. >> >> Ah, thanks. I had a squash queued on top but will replace with this >

Re: [PATCHv3] submodule--helper: normalize funny urls

2016-10-18 Thread Junio C Hamano
Junio C Hamano writes: > Stefan Beller writes: > >> The remote URL for the submodule can be specified relative >> ... >> v3: >> * fixed the coding style. > > Ah, thanks. I had a squash queued on top but will replace with this > one. Heh, I guess I shouldn't have responded before seeing what t

Re: [PATCHv3] submodule--helper: normalize funny urls

2016-10-18 Thread Junio C Hamano
Stefan Beller writes: > The remote URL for the submodule can be specified relative > ... > v3: > * fixed the coding style. Ah, thanks. I had a squash queued on top but will replace with this one.

[PATCHv3] submodule--helper: normalize funny urls

2016-10-18 Thread Stefan Beller
The remote URL for the submodule can be specified relative to the URL of the superproject in .gitmodules. A top-level git://site.xz/toplevel.git can specify in its .gitmodules [submodule "sub"] url = ../submodule.git path = sub to say that git://site.xz/su