Re: [PATCHv3] pathspec: allow escaped query values

2016-06-02 Thread Stefan Beller
On Thu, Jun 2, 2016 at 4:23 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> However if we add a value restriction here, we need to be as strict in the >> .gitattributes parsing as well and put a warning there (similar to >> invalid_attr_name_message) I would think. > > Remember, the attrib

Re: [PATCHv3] pathspec: allow escaped query values

2016-06-02 Thread Junio C Hamano
Stefan Beller writes: > However if we add a value restriction here, we need to be as strict in the > .gitattributes parsing as well and put a warning there (similar to > invalid_attr_name_message) I would think. Remember, the attribute system is used for many purposes other than this new "furthe

[PATCHv3] pathspec: allow escaped query values

2016-06-02 Thread Stefan Beller
In our own .gitattributes file we have attributes such as: *.[ch] whitespace=indent,trail,space When querying for attributes we want to be able to ask for the exact value, i.e. git ls-files :(attr:whitespace=indent,trail,space) should work, but the commas are used in the attr magic to i