Re: [PATCHv2 3/5] submodule--helper clone: remove double path checking

2016-03-31 Thread Junio C Hamano
Eric Sunshine writes: > On Thu, Mar 31, 2016 at 5:04 PM, Stefan Beller wrote: >> submodule--helper clone: remove double path checking > > I think Junio mentioned in v1 that calling this "path checking" is misleading. I'd tentatively use: "submodule--helper clone: create the submodule path

Re: [PATCHv2 3/5] submodule--helper clone: remove double path checking

2016-03-31 Thread Eric Sunshine
On Thu, Mar 31, 2016 at 5:04 PM, Stefan Beller wrote: > submodule--helper clone: remove double path checking I think Junio mentioned in v1 that calling this "path checking" is misleading. > We make sure that the parent directory of path exists (or create it > otherwise) and then do the same for

[PATCHv2 3/5] submodule--helper clone: remove double path checking

2016-03-31 Thread Stefan Beller
We make sure that the parent directory of path exists (or create it otherwise) and then do the same for path + "/.git". That is equivalent to just making sure that the parent directory of path + "/.git" exists (or create it otherwise). Signed-off-by: Stefan Beller --- builtin/submodule--helper.