Re: [PATCHv2 1/6] submodule.c: add has_submodules to check if we have any submodules

2017-05-23 Thread Stefan Beller
On Tue, May 23, 2017 at 11:40 AM, Brandon Williams wrote: > It doesn't look like any patches actually use this helper, is this > intended? It was needed for https://public-inbox.org/git/20170411194616.4963-1-sbel...@google.com/ which we do not have in this series any more. Will drop this patch.

Re: [PATCHv2 1/6] submodule.c: add has_submodules to check if we have any submodules

2017-05-23 Thread Brandon Williams
On 05/22, Stefan Beller wrote: > When submodules are involved, it often slows down the process, as most > submodule related handling is either done via a child process or by > iterating over the index finding all gitlinks. > > For most commands that may interact with submodules, we need have a > q

[PATCHv2 1/6] submodule.c: add has_submodules to check if we have any submodules

2017-05-22 Thread Stefan Beller
When submodules are involved, it often slows down the process, as most submodule related handling is either done via a child process or by iterating over the index finding all gitlinks. For most commands that may interact with submodules, we need have a quick check if we do have any submodules at