Re: [PATCHv2 1/2] push: change submodule default to check when submodules exist

2016-10-04 Thread Stefan Beller
On Tue, Oct 4, 2016 at 12:39 PM, Jeff King wrote: > On Tue, Oct 04, 2016 at 12:29:09PM -0700, Stefan Beller wrote: > >> Jeff wrote: >> > Consulting .git/config is fine, I think. It's not like we don't read it >> > (sometimes multiple times!) during the normal course of the program >> > anyway. It'

Re: [PATCHv2 1/2] push: change submodule default to check when submodules exist

2016-10-04 Thread Jeff King
On Tue, Oct 04, 2016 at 12:29:09PM -0700, Stefan Beller wrote: > Jeff wrote: > > Consulting .git/config is fine, I think. It's not like we don't read it > > (sometimes multiple times!) during the normal course of the program > > anyway. It's just a question of whether it makes more sense for the >

[PATCHv2 1/2] push: change submodule default to check when submodules exist

2016-10-04 Thread Stefan Beller
When working with submodules, it is easy to forget to push the submodules. The setting 'check', which checks if any existing submodule is present on at least one remote of the submodule remotes, is designed to prevent this mistake. Flipping the default to check for submodules is safer than the cur