Re: [PATCHv2 0/10] pkt-line and remote-curl cleanups server

2013-02-19 Thread Shawn Pearce
On Mon, Feb 18, 2013 at 1:49 AM, Junio C Hamano wrote: > Jeff King writes: > >> On Mon, Feb 18, 2013 at 01:29:16AM -0800, Junio C Hamano wrote: >> >>> > I just checked, and GitHub also does not send flush packets after ERR. >>> > Which makes sense; ERR is supposed to end the conversation. >>> >>>

Re: [PATCHv2 0/10] pkt-line and remote-curl cleanups server

2013-02-19 Thread Shawn Pearce
On Mon, Feb 18, 2013 at 1:12 AM, Jeff King wrote: > On Sun, Feb 17, 2013 at 05:41:13PM -0800, Jonathan Nieder wrote: > >> > I don't think so. Don't ERR lines appear inside their own packets? >> >> Yes, I misread get_remote_heads for some reason. Thanks for checking. > > Thanks for bringing it up.

Re: [PATCHv2 0/10] pkt-line and remote-curl cleanups server

2013-02-18 Thread Jeff King
On Mon, Feb 18, 2013 at 01:49:37AM -0800, Junio C Hamano wrote: > The logic behind the comment "we do not buffer, but we should" is > that flush tells the receiver that the sending end is "done" feeding > it a class of data, and the data before flush do not have to reach > the receiver immediately

Re: [PATCHv2 0/10] pkt-line and remote-curl cleanups server

2013-02-18 Thread Junio C Hamano
Jeff King writes: > On Mon, Feb 18, 2013 at 01:29:16AM -0800, Junio C Hamano wrote: > >> > I just checked, and GitHub also does not send flush packets after ERR. >> > Which makes sense; ERR is supposed to end the conversation. >> >> Hmph. A flush packet was supposed to be a mark to say "all the

Re: [PATCHv2 0/10] pkt-line and remote-curl cleanups server

2013-02-18 Thread Jeff King
On Mon, Feb 18, 2013 at 01:29:16AM -0800, Junio C Hamano wrote: > > I just checked, and GitHub also does not send flush packets after ERR. > > Which makes sense; ERR is supposed to end the conversation. > > Hmph. A flush packet was supposed to be a mark to say "all the > packets before this one

Re: [PATCHv2 0/10] pkt-line and remote-curl cleanups server

2013-02-18 Thread Junio C Hamano
Jeff King writes: > On Sun, Feb 17, 2013 at 05:41:13PM -0800, Jonathan Nieder wrote: > >> > I don't think so. Don't ERR lines appear inside their own packets? >> >> Yes, I misread get_remote_heads for some reason. Thanks for checking. > > Thanks for bringing it up. I had not even thought about

[PATCHv2 0/10] pkt-line and remote-curl cleanups server

2013-02-18 Thread Jeff King
On Sun, Feb 17, 2013 at 05:41:13PM -0800, Jonathan Nieder wrote: > > I don't think so. Don't ERR lines appear inside their own packets? > > Yes, I misread get_remote_heads for some reason. Thanks for checking. Thanks for bringing it up. I had not even thought about ERR at all. So it was luck ra