Re: [PATCHv2] unpack-trees: move checkout state into check_updates

2017-01-06 Thread Stefan Beller
On Sat, Dec 31, 2016 at 5:26 PM, Junio C Hamano wrote: >> Signed-off-by: Stefan Beller >> --- > > I'd add René's Reviewed-by: here. done > > I think moving heavier and initialized variables earlier and more > lightweight and ephemeral ones like "i" later does make it easier to > follow. "errs"

Re: [PATCHv2] unpack-trees: move checkout state into check_updates

2016-12-31 Thread Junio C Hamano
Stefan Beller writes: > The checkout state was introduced via 16da134b1f9 > (read-trees: refactor the unpack_trees() part, 2006-07-30). An attempt to > refactor the checkout state was done in b56aa5b268e (unpack-trees: pass > checkout state explicitly to check_updates(), 2016-09-13), but we can >

[PATCHv2] unpack-trees: move checkout state into check_updates

2016-12-29 Thread Stefan Beller
The checkout state was introduced via 16da134b1f9 (read-trees: refactor the unpack_trees() part, 2006-07-30). An attempt to refactor the checkout state was done in b56aa5b268e (unpack-trees: pass checkout state explicitly to check_updates(), 2016-09-13), but we can go even further. The `struct che