Re: [PATCHv2] submodule.c: use GIT_DIR_ENVIRONMENT consistently

2017-01-03 Thread Jeff King
On Tue, Jan 03, 2017 at 10:30:47AM -0800, Stefan Beller wrote: > In C code we have the luxury of having constants for all the important > things that are hard coded. This is the only place in C, that hard codes > the git directory environment variable, so fix it. > > Signed-off-by: Stefan Beller

[PATCHv2] submodule.c: use GIT_DIR_ENVIRONMENT consistently

2017-01-03 Thread Stefan Beller
In C code we have the luxury of having constants for all the important things that are hard coded. This is the only place in C, that hard codes the git directory environment variable, so fix it. Signed-off-by: Stefan Beller --- v2: argv_array_pushf and realigned. v1: Signed-off-by-the-forma