Re: [PATCHv2] pathspec: allow escaped query values

2016-06-02 Thread Junio C Hamano
Stefan Beller writes: > Thinking about efficiency, I have the believe that memmove can be faster > than a `*src=*dst` thing we do ourselves as it may have access to specialized > assembly instructions to move larger chunks of memory or such. > So I think ideally we would do a block copy between

Re: [PATCHv2] pathspec: allow escaped query values

2016-06-02 Thread Stefan Beller
On Thu, Jun 2, 2016 at 2:54 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> In our own .gitattributes file we have attributes such as: >> >> *.[ch] whitespace=indent,trail,space >> >> When querying for attributes we want to be able to ask for the exact >> value, i.e. >> >> git ls-f

Re: [PATCHv2] pathspec: allow escaped query values

2016-06-02 Thread Stefan Beller
On Thu, Jun 2, 2016 at 2:54 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> In our own .gitattributes file we have attributes such as: >> >> *.[ch] whitespace=indent,trail,space >> >> When querying for attributes we want to be able to ask for the exact >> value, i.e. >> >> git ls-f

Re: [PATCHv2] pathspec: allow escaped query values

2016-06-02 Thread Junio C Hamano
Stefan Beller writes: > In our own .gitattributes file we have attributes such as: > > *.[ch] whitespace=indent,trail,space > > When querying for attributes we want to be able to ask for the exact > value, i.e. > > git ls-files :(attr:whitespace=indent,trail,space) > > should work, but th

[PATCHv2] pathspec: allow escaped query values

2016-06-02 Thread Stefan Beller
In our own .gitattributes file we have attributes such as: *.[ch] whitespace=indent,trail,space When querying for attributes we want to be able to ask for the exact value, i.e. git ls-files :(attr:whitespace=indent,trail,space) should work, but the commas are used in the attr magic to i