Re: [PATCHv2] parse-options: report uncorrupted multi-byte options

2013-02-11 Thread Duy Nguyen
On Tue, Feb 12, 2013 at 9:10 AM, Junio C Hamano wrote: >> Similar cases: >> >> config.c:git_default_core_config() assumes core.commentchar is ascii. >> We should catch and report non-ascii chars, or simply accept it as a >> string. > > That one is just an uninterpreted byte. core.commentString mi

Re: [PATCHv2] parse-options: report uncorrupted multi-byte options

2013-02-11 Thread Junio C Hamano
Duy Nguyen writes: > On Tue, Feb 12, 2013 at 6:13 AM, Erik Faye-Lund wrote: >> Because our command-line parser considers only one byte at the time >> for short-options, we incorrectly report only the first byte when >> multi-byte input was provided. This makes user-erros slightly >> awkward to d

Re: [PATCHv2] parse-options: report uncorrupted multi-byte options

2013-02-11 Thread Duy Nguyen
On Tue, Feb 12, 2013 at 6:13 AM, Erik Faye-Lund wrote: > Because our command-line parser considers only one byte at the time > for short-options, we incorrectly report only the first byte when > multi-byte input was provided. This makes user-erros slightly > awkward to diagnose for instance under

Re: [PATCHv2] parse-options: report uncorrupted multi-byte options

2013-02-11 Thread Jeff King
On Tue, Feb 12, 2013 at 12:13:48AM +0100, Erik Faye-Lund wrote: > I decided to change the text from what Jeff suggested; all we know is > that it's non-ASCII. It might be Latin-1 or some other non-ASCII, > single byte encoding. And since we're trying not to care, let's also > try to not be overly

Re: [PATCHv2] parse-options: report uncorrupted multi-byte options

2013-02-11 Thread Junio C Hamano
Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCHv2] parse-options: report uncorrupted multi-byte options

2013-02-11 Thread Erik Faye-Lund
Because our command-line parser considers only one byte at the time for short-options, we incorrectly report only the first byte when multi-byte input was provided. This makes user-erros slightly awkward to diagnose for instance under UTF-8 locale and non-English keyboard layouts. Make the reporti