Re: [PATCHv18 00/11] Expose

2016-02-25 Thread Junio C Hamano
On Thu, Feb 25, 2016 at 3:35 PM, Jonathan Nieder wrote: > Interesting --- git sets a GIT_PREFIX environment variable (in the > same spirit as GIT_WORK_TREE) but doesn't read it. I think that is because it is meant for helping end-user scripts that are called by us; they would not know where the e

Re: [PATCHv18 00/11] Expose

2016-02-25 Thread Jonathan Nieder
Stefan Beller wrote: > On Thu, Feb 25, 2016 at 3:19 PM, Jonathan Nieder wrote: > > Now that I look around more, it seems that other submodule--helper > > subcommands > > have the same strange behavior of overwriting the 'prefix' var. So I take > > back my suggestion of using a different variabl

Re: [PATCHv18 00/11] Expose

2016-02-25 Thread Jonathan Nieder
Stefan Beller wrote: > Interdiff to v17: Except for the bit about 'prefix', Reviewed-by: Jonathan Nieder -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCHv18 00/11] Expose

2016-02-25 Thread Stefan Beller
On Thu, Feb 25, 2016 at 3:19 PM, Jonathan Nieder wrote: > Stefan Beller wrote: > >> --- a/builtin/submodule--helper.c >> +++ b/builtin/submodule--helper.c >> @@ -465,14 +465,14 @@ static int update_clone(int argc, const char **argv, >> const char *prefix) >> NULL >> }; >> >> -

Re: [PATCHv18 00/11] Expose

2016-02-25 Thread Jonathan Nieder
Stefan Beller wrote: > --- a/builtin/submodule--helper.c > +++ b/builtin/submodule--helper.c > @@ -465,14 +465,14 @@ static int update_clone(int argc, const char **argv, > const char *prefix) > NULL > }; > > - argc = parse_options(argc, argv, prefix, module_update_clone_

Re: [PATCHv18 00/11] Expose

2016-02-25 Thread Stefan Beller
On Thu, Feb 25, 2016 at 3:08 PM, Stefan Beller wrote: Subject: Expose ... submodule parallelism to the user Does git-send-email cache information after invoking it? i.e. Am I not supposed to edit the patch files after invoking git send-mail, before confirming to send them out actually? Thanks

[PATCHv18 00/11] Expose

2016-02-25 Thread Stefan Beller
* fixes the test breakage (which was caused by a last minute fix :/ to the prefix variable handling) * include the separately sent patch to not call fwrite in case of length 0 Thanks, Stefan Interdiff to v17: diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c index 9d94406.