Re: [PATCHv10 02/10] receive-pack.c: die instead of error in assure_connectivity_checked

2015-01-05 Thread Jonathan Nieder
Stefan Beller wrote: > Maybe we should do both? > > die ("BUG: Some refs have not been checked for connectivity." > "Please contact the git developers (git@vger.kernel.org) and" > "report the problem. As a workaround run 'git fsck'. If there" > "are errors, try to

Re: [PATCHv10 02/10] receive-pack.c: die instead of error in assure_connectivity_checked

2015-01-05 Thread Stefan Beller
On Mon, Jan 5, 2015 at 12:17 PM, Jonathan Nieder wrote: > Stefan Beller wrote: > >> --- a/builtin/receive-pack.c >> +++ b/builtin/receive-pack.c >> @@ -1055,15 +1055,15 @@ static void assure_connectivity_checked(struct >> command *commands, >> >> for (cmd = commands; cmd; cmd = cmd->next) {

Re: [PATCHv10 02/10] receive-pack.c: die instead of error in assure_connectivity_checked

2015-01-05 Thread Jonathan Nieder
Stefan Beller wrote: > --- a/builtin/receive-pack.c > +++ b/builtin/receive-pack.c > @@ -1055,15 +1055,15 @@ static void assure_connectivity_checked(struct > command *commands, > > for (cmd = commands; cmd; cmd = cmd->next) { > if (should_process_cmd(cmd) && si->shallow_ref[

[PATCHv10 02/10] receive-pack.c: die instead of error in assure_connectivity_checked

2015-01-05 Thread Stefan Beller
Discussion on the previous patch revealed we rather want to err on the safe side. To do so we need to stop receive-pack in case of the possible future bug when connectivity is not checked on a shallow push. Suggested-by: Jonathan Nieder Signed-off-by: Stefan Beller --- Notes: v10: * new