Re: [PATCH v9 4/5] dir_iterator: refactor state machine model

2017-04-17 Thread Junio C Hamano
Daniel Ferreira writes: > ... > Signed-off-by: Daniel Ferreira > Signed-off-by: Michael Haggerty I had an impression that you took Michael's code snippet and wrote this patch, and if that is the case, the flow of the patch is from Michael to you to me, so these lines are out of order. Describ

Re: [PATCH v9 4/5] dir_iterator: refactor state machine model

2017-04-17 Thread Junio C Hamano
Daniel Ferreira writes: > Perform major refactor of dir_iterator_advance(). dir_iterator has > ceased to rely on a convoluted state machine mechanism of two loops and > two state variables (level.initialized and level.dir_state). This serves > to ease comprehension of the iterator mechanism and e

[PATCH v9 4/5] dir_iterator: refactor state machine model

2017-04-17 Thread Daniel Ferreira
Perform major refactor of dir_iterator_advance(). dir_iterator has ceased to rely on a convoluted state machine mechanism of two loops and two state variables (level.initialized and level.dir_state). This serves to ease comprehension of the iterator mechanism and ease addition of new features to th