Re: [PATCH v9 3/6] note: extract parse_notes_merge_strategy to notes-utils

2015-08-17 Thread Jacob Keller
On Mon, Aug 17, 2015 at 3:38 PM, Junio C Hamano wrote: > Jacob Keller writes: > >> From: Jacob Keller >> >> Combining rewrite and notes-merge functionality has been left as an >> exercise for a future contributor. > > This comment is probably unnecessary; we haven't even established if > such a

Re: [PATCH v9 3/6] note: extract parse_notes_merge_strategy to notes-utils

2015-08-17 Thread Junio C Hamano
Jacob Keller writes: > From: Jacob Keller > > Combining rewrite and notes-merge functionality has been left as an > exercise for a future contributor. This comment is probably unnecessary; we haven't even established if such a combination is desirable AFAICT in the discussion. The patch itself

[PATCH v9 3/6] note: extract parse_notes_merge_strategy to notes-utils

2015-08-17 Thread Jacob Keller
From: Jacob Keller Combining rewrite and notes-merge functionality has been left as an exercise for a future contributor. Signed-off-by: Jacob Keller --- builtin/notes.c | 12 +--- notes-utils.c | 18 ++ notes-utils.h | 1 + 3 files changed, 20 insertions(+), 11 de