Re: [PATCH v9 3/3] commit: add a commit.verbose config variable

2016-03-24 Thread Pranit Bauva
On Fri, Mar 25, 2016 at 5:35 AM, Eric Sunshine wrote: > On Thu, Mar 24, 2016 at 4:25 AM, Pranit Bauva wrote: >> Add commit.verbose configuration variable as a convenience for those >> who always prefer --verbose. > > The implementation looks better in this version. A couple comments > below about

Re: [PATCH v9 3/3] commit: add a commit.verbose config variable

2016-03-24 Thread Eric Sunshine
On Thu, Mar 24, 2016 at 4:25 AM, Pranit Bauva wrote: > Add commit.verbose configuration variable as a convenience for those > who always prefer --verbose. The implementation looks better in this version. A couple comments below about the test script... > Signed-off-by: Pranit Bauva > --- > diff

Re: [PATCH v9 3/3] commit: add a commit.verbose config variable

2016-03-24 Thread Pranit Bauva
I got it. The verbose is initialised to -1 before. When cmd_commit runs, it changes the value of verbose accordingly to 0 or positive. But when cmd_status runs, it will retain the value -1 and the if clause which accepts all values except 0 will execute. I guess a if statement inside cmd_status whi

Re: [PATCH v9 3/3] commit: add a commit.verbose config variable

2016-03-24 Thread Pranit Bauva
On Thu, Mar 24, 2016 at 3:34 PM, SZEDER Gábor wrote: >> Add commit.verbose configuration variable as a convenience for those >> who always prefer --verbose. >> >> Helped-by: Junio C Hamano >> Helped-by: Eric Sunshine >> Signed-off-by: Pranit Bauva >> >> --- >> The previous version of the patch

Re: [PATCH v9 3/3] commit: add a commit.verbose config variable

2016-03-24 Thread SZEDER Gábor
> Add commit.verbose configuration variable as a convenience for those > who always prefer --verbose. > > Helped-by: Junio C Hamano > Helped-by: Eric Sunshine > Signed-off-by: Pranit Bauva > > --- > The previous version of the patch are: > - [v8] $gmane/288820 > - [v7] $gmane/288820 > - [v6

[PATCH v9 3/3] commit: add a commit.verbose config variable

2016-03-24 Thread Pranit Bauva
Add commit.verbose configuration variable as a convenience for those who always prefer --verbose. Helped-by: Junio C Hamano Helped-by: Eric Sunshine Signed-off-by: Pranit Bauva --- The previous version of the patch are: - [v8] $gmane/288820 - [v7] $gmane/288820 - [v6] $gmane/288728 - [v5]