Re: [PATCH v9 1/3] parse-options.c: make OPTION__COUNTUP consider negative values

2016-03-28 Thread Eric Sunshine
On Mon, Mar 28, 2016 at 2:42 PM, Pranit Bauva wrote: >> A couple of new tests to t0040-parse-options.sh would be great to >> ensure that starting from a negative value works as advertised, i.e. >> at least that '--option' jumps to 1 and '--no-option' resets to 0. > > I think adding tests to t0040-

Re: [PATCH v9 1/3] parse-options.c: make OPTION__COUNTUP consider negative values

2016-03-28 Thread Pranit Bauva
> A couple of new tests to t0040-parse-options.sh would be great to > ensure that starting from a negative value works as advertised, i.e. > at least that '--option' jumps to 1 and '--no-option' resets to 0. I think adding tests to t0040-parse-options.sh cannot reflect the behavior introduced by t

Re: [PATCH v9 1/3] parse-options.c: make OPTION__COUNTUP consider negative values

2016-03-24 Thread Eric Sunshine
On Thu, Mar 24, 2016 at 6:33 AM, SZEDER Gábor wrote: >> The reason to make it consider negative values or more specifically >> "unspecified" values is to give the ability to differentiate between >> once, multiple time or with --no-option. >> >> Eg. : >> initialize verbose = -1 >> `git commit` =>

Re: [PATCH v9 1/3] parse-options.c: make OPTION__COUNTUP consider negative values

2016-03-24 Thread Pranit Bauva
On Thu, Mar 24, 2016 at 4:03 PM, SZEDER Gábor wrote: >> The reason to make it consider negative values or more specifically >> "unspecified" values is to give the ability to differentiate between >> once, multiple time or with --no-option. >> >> Eg. : >> initialize verbose = -1 >> `git commit` =>

[PATCH v9 1/3] parse-options.c: make OPTION__COUNTUP consider negative values

2016-03-24 Thread SZEDER Gábor
> The reason to make it consider negative values or more specifically > "unspecified" values is to give the ability to differentiate between > once, multiple time or with --no-option. > > Eg. : > initialize verbose = -1 > `git commit` => verbose = -1 > `git commit -v` => verbose = 1 > `git commit

[PATCH v9 1/3] parse-options.c: make OPTION__COUNTUP consider negative values

2016-03-24 Thread Pranit Bauva
The reason to make it consider negative values or more specifically "unspecified" values is to give the ability to differentiate between once, multiple time or with --no-option. Eg. : initialize verbose = -1 `git commit` => verbose = -1 `git commit -v` => verbose = 1 `git commit -v -v` => verbose