Re: [PATCH v9 07/11] sequencer.c: remove duplicate code

2019-03-26 Thread Phillip Wood
On 21/03/2019 06:53, Denton Liu wrote: Since we implemented get_cleanup_mode, we had some duplicate code in git_sequencer_config which essentially performed the same operations. Refactor git_sequencer_config to take advantage of the logic already in get_cleanup_mode. Note that we had to intro

[PATCH v9 07/11] sequencer.c: remove duplicate code

2019-03-20 Thread Denton Liu
Since we implemented get_cleanup_mode, we had some duplicate code in git_sequencer_config which essentially performed the same operations. Refactor git_sequencer_config to take advantage of the logic already in get_cleanup_mode. Note that we had to introduce a separate argument to get_cleanup_mode