Re: [PATCH v9] git on Mac OS and precomposed unicode

2012-08-16 Thread Junio C Hamano
Junio C Hamano writes: > Robin Rosenberg writes: > >> Just a couple of nitpicks. > > Polishing is always good and better late than never, but for a topic > that has long been graduated to 'master' already, it would be easier > to review and discuss if it came as a patch form relative to the > co

Re: [PATCH v9] git on Mac OS and precomposed unicode

2012-07-26 Thread Junio C Hamano
Robin Rosenberg writes: > Just a couple of nitpicks. Polishing is always good and better late than never, but for a topic that has long been graduated to 'master' already, it would be easier to review and discuss if it came as a patch form relative to the codebase _after_ the topic has been appl

Re: [PATCH v9] git on Mac OS and precomposed unicode

2012-07-26 Thread Robin Rosenberg
Just a couple of nitpicks. Torsten Bögershausen skrev 2012-07-08 15.50: diff --git a/compat/precompose_utf8.c b/compat/precompose_utf8.c [...] +static size_t has_utf8(const char *s, size_t maxlen, size_t *strlen_c) +{ + const uint8_t *utf8p = (const uint8_t*) s; + size_t strlen_cha

[PATCH v9] git on Mac OS and precomposed unicode

2012-07-08 Thread Torsten Bögershausen
Mac OS X mangles file names containing unicode on file systems HFS+, VFAT or SAMBA. When a file using unicode code points outside ASCII is created on a HFS+ drive, the file name is converted into decomposed unicode and written to disk. No conversion is done if the file name is already decomposed u