Re: [PATCH v8 6/8] submodule: refactor show_submodule_summary with helper function

2016-08-19 Thread Jacob Keller
On Fri, Aug 19, 2016 at 1:24 PM, Junio C Hamano wrote: > And probably merge_bases also leaks here. > > It is not cheap to compute merge bases, but show_submodule_summary() > makes two calls to get_merge_bases(), one in show_submodule_header() > and then another inside prepare_submodule_summary() t

Re: [PATCH v8 6/8] submodule: refactor show_submodule_summary with helper function

2016-08-19 Thread Junio C Hamano
Jacob Keller writes: > @@ -290,12 +289,6 @@ static int prepare_submodule_summary(struct rev_info > *rev, const char *path, > add_pending_object(rev, &left->object, path); > add_pending_object(rev, &right->object, path); > merge_bases = get_merge_bases(left, right); > - if (

[PATCH v8 6/8] submodule: refactor show_submodule_summary with helper function

2016-08-18 Thread Jacob Keller
From: Jacob Keller A future patch is going to add a new submodule diff format which displays an inline diff of the submodule changes. To make this easier, and to ensure that both submodule diff formats use the same initial header, factor out show_submodule_header() function which will print the c