Re: [PATCH v8 5/7] revision: mark non-user-given objects instead

2018-09-14 Thread Matthew DeVore
On Fri, Sep 14, 2018 at 10:23 AM Junio C Hamano wrote: > > Matthew DeVore writes: > > > Signed-off-by: Matthew DeVore > > > > fixup of 6defd70de > > That's probably meant to go below "---". > That line shouldn't be there at all, sorry! It came from me putting that text in a commit which was me

Re: [PATCH v8 5/7] revision: mark non-user-given objects instead

2018-09-14 Thread Junio C Hamano
Matthew DeVore writes: > Currently, list-objects.c incorrectly treats all root trees of commits > as USER_GIVEN. Also, it would be easier to mark objects that are > non-user-given instead of user-given, since the places in the code > where we access an object through a reference are more obvious

[PATCH v8 5/7] revision: mark non-user-given objects instead

2018-09-13 Thread Matthew DeVore
Currently, list-objects.c incorrectly treats all root trees of commits as USER_GIVEN. Also, it would be easier to mark objects that are non-user-given instead of user-given, since the places in the code where we access an object through a reference are more obvious than the places where we access a