Re: [PATCH v8 32/44] refs.c: remove the update_ref_write function

2014-05-22 Thread Ronnie Sahlberg
On Wed, May 21, 2014 at 3:07 PM, Jonathan Nieder wrote: > Ronnie Sahlberg wrote: > >> +++ b/refs.c > [...] >> @@ -3518,14 +3499,16 @@ int ref_transaction_commit(struct ref_transaction >> *transaction, >> struct ref_update *update = updates[i]; >> >> if (!is_null_sha1(u

Re: [PATCH v8 32/44] refs.c: remove the update_ref_write function

2014-05-21 Thread Jonathan Nieder
Ronnie Sahlberg wrote: > +++ b/refs.c [...] > @@ -3518,14 +3499,16 @@ int ref_transaction_commit(struct ref_transaction > *transaction, > struct ref_update *update = updates[i]; > > if (!is_null_sha1(update->new_sha1)) { > - ret = update_ref_write

[PATCH v8 32/44] refs.c: remove the update_ref_write function

2014-05-15 Thread Ronnie Sahlberg
Since we only call update_ref_write from a single place and we only call it with onerr==QUIET_ON_ERR we can just as well get rid of it and just call write_ref_sha1 directly. Signed-off-by: Ronnie Sahlberg --- refs.c | 35 +-- 1 file changed, 9 insertions(+), 26 de