Re: [PATCH v8 08/14] commit-graph: implement git commit-graph read

2018-04-14 Thread Eric Sunshine
On Sat, Apr 14, 2018 at 6:15 PM, Jakub Narebski wrote: > Derrick Stolee writes: >> + NUM_CHUNKS=$((3 + $(echo "$2" | wc -w))) > > I don't know if it is possible to do the above in a portable shell > without using external 'wc' command. Also, isn't $(( ... )) bashism? $((...)) is POS

Re: [PATCH v8 08/14] commit-graph: implement git commit-graph read

2018-04-14 Thread Jakub Narebski
Derrick Stolee writes: > From: Derrick Stolee > Subject: [PATCH v8 08/14] commit-graph: implement git commit-graph read Minor nit: this is one commit message [subject] among all others that uses "git commit-graph" instead of "git-commit-graph" in the description

[PATCH v8 08/14] commit-graph: implement git commit-graph read

2018-04-10 Thread Derrick Stolee
From: Derrick Stolee Teach git-commit-graph to read commit graph files and summarize their contents. Use the read subcommand to verify the contents of a commit graph file in the tests. Signed-off-by: Derrick Stolee --- Documentation/git-commit-graph.txt | 12 +++ builtin/commit-graph.c