Re: [PATCH v8 02/44] refs.c: allow passing NULL to ref_transaction_free

2014-05-15 Thread Ronnie Sahlberg
Thanks. I used your improved text in the commit message. On Thu, May 15, 2014 at 11:15 AM, Jonathan Nieder wrote: > Ronnie Sahlberg wrote: > >> Allow ref_transaction_free to be called with NULL and as a result allow >> ref_transaction_rollback to be called for a NULL transaction. >> >> This allo

Re: [PATCH v8 02/44] refs.c: allow passing NULL to ref_transaction_free

2014-05-15 Thread Jonathan Nieder
Ronnie Sahlberg wrote: > Allow ref_transaction_free to be called with NULL and as a result allow > ref_transaction_rollback to be called for a NULL transaction. > > This allows us to write code that will > if ( (!transaction || > ref_transaction_update(...)) || > (ref_transaction_

[PATCH v8 02/44] refs.c: allow passing NULL to ref_transaction_free

2014-05-15 Thread Ronnie Sahlberg
Allow ref_transaction_free to be called with NULL and as a result allow ref_transaction_rollback to be called for a NULL transaction. This allows us to write code that will if ( (!transaction || ref_transaction_update(...)) || (ref_transaction_commit(...) && !(transaction = NULL))