Re: [PATCH v8] read-cache: call verify_hdr() in a background thread

2017-04-26 Thread Junio C Hamano
Jeff Hostetler writes: > Either version is fine. I'd say use my perl version as I have tested it and > it is simple enough and already in the tree. I don't think it's worth the > bother to switch it to the dd version. Thanks, I agree what you said is very sensible.

Re: [PATCH v8] read-cache: call verify_hdr() in a background thread

2017-04-26 Thread Jeff Hostetler
On 4/26/2017 12:34 AM, Junio C Hamano wrote: Junio C Hamano writes: g...@jeffhostetler.com writes: From: Jeff Hostetler Version 8 of this patch converts the unit test to use perl to corrupt the index checksum (rather than altering a filename) and also verifies the fsck error message as s

Re: [PATCH v8] read-cache: call verify_hdr() in a background thread

2017-04-26 Thread Jeff Hostetler
On 4/26/2017 12:11 AM, Junio C Hamano wrote: g...@jeffhostetler.com writes: From: Jeff Hostetler Version 8 of this patch converts the unit test to use perl to corrupt the index checksum (rather than altering a filename) and also verifies the fsck error message as suggested in response to v7

Re: [PATCH v8] read-cache: call verify_hdr() in a background thread

2017-04-25 Thread Junio C Hamano
Junio C Hamano writes: > g...@jeffhostetler.com writes: > >> From: Jeff Hostetler >> >> Version 8 of this patch converts the unit test to use >> perl to corrupt the index checksum (rather than altering >> a filename) and also verifies the fsck error message as >> suggested in response to v7 on t

Re: [PATCH v8] read-cache: call verify_hdr() in a background thread

2017-04-25 Thread Junio C Hamano
g...@jeffhostetler.com writes: > From: Jeff Hostetler > > Version 8 of this patch converts the unit test to use > perl to corrupt the index checksum (rather than altering > a filename) and also verifies the fsck error message as > suggested in response to v7 on the mailing list. > > If there are

[PATCH v8] read-cache: call verify_hdr() in a background thread

2017-04-25 Thread git
From: Jeff Hostetler Version 8 of this patch converts the unit test to use perl to corrupt the index checksum (rather than altering a filename) and also verifies the fsck error message as suggested in response to v7 on the mailing list. If there are no other suggestions, I think this version sho