Re: [PATCH v7 5/7] revision: mark non-user-given objects instead

2018-09-05 Thread Matthew DeVore
On Tue, Sep 4, 2018 at 1:31 PM Junio C Hamano wrote: > > Matthew DeVore writes: > > > diff --git a/revision.h b/revision.h > > index 51189..2d381e636 100644 > > --- a/revision.h > > +++ b/revision.h > > @@ -8,7 +8,11 @@ > > #include "diff.h" > > #include "commit-slab-decl.h" > > > > -/* Rem

Re: [PATCH v7 5/7] revision: mark non-user-given objects instead

2018-09-04 Thread Junio C Hamano
Matthew DeVore writes: > diff --git a/revision.h b/revision.h > index 51189..2d381e636 100644 > --- a/revision.h > +++ b/revision.h > @@ -8,7 +8,11 @@ > #include "diff.h" > #include "commit-slab-decl.h" > > -/* Remember to update object flag allocation in object.h */ > +/* Remember to upd

[PATCH v7 5/7] revision: mark non-user-given objects instead

2018-09-04 Thread Matthew DeVore
Currently, list-objects.c incorrectly treats all root trees of commits as USER_GIVEN. Also, it would be easier to mark objects that are non-user-given instead of user-given, since the places in the code where we access an object through a reference are more obvious than the places where we access a