Re: [PATCH v7 4/8] sequencer.c: remove duplicate code

2019-03-11 Thread Phillip Wood
Hi Denton One small comment below, this basically looks fine to me On 11/03/2019 03:42, Denton Liu wrote: Since we implemented get_cleanup_mode, we had some duplicate code in git_sequencer_config which essentially performed the same operations. Refactor git_sequencer_config to take advantage of

[PATCH v7 4/8] sequencer.c: remove duplicate code

2019-03-10 Thread Denton Liu
Since we implemented get_cleanup_mode, we had some duplicate code in git_sequencer_config which essentially performed the same operations. Refactor git_sequencer_config to take advantage of the logic already in get_cleanup_mode. Note that we had to introduce a separate argument to get_cleanup_mode