Re: [PATCH v7 08/13] pack-objects: shrink z_delta_size field in struct object_entry

2018-03-31 Thread Jeff King
On Sat, Mar 31, 2018 at 06:40:23AM +0200, Duy Nguyen wrote: > > Unlike the depth, I don't think there's any _inherent_ reason you > > couldn't throw, say, 1MB deltas into the cache (if you sized it large > > enough). But I doubt such deltas are really all that common. Here are > > the top 10 in li

Re: [PATCH v7 08/13] pack-objects: shrink z_delta_size field in struct object_entry

2018-03-30 Thread Duy Nguyen
On Fri, Mar 30, 2018 at 10:59 PM, Jeff King wrote: > On Sat, Mar 24, 2018 at 07:33:48AM +0100, Nguyễn Thái Ngọc Duy wrote: > >> We only cache deltas when it's smaller than a certain limit. This limit >> defaults to 1000 but save its compressed length in a 64-bit field. >> Shrink that field down to

Re: [PATCH v7 08/13] pack-objects: shrink z_delta_size field in struct object_entry

2018-03-30 Thread Jeff King
On Sat, Mar 24, 2018 at 07:33:48AM +0100, Nguyễn Thái Ngọc Duy wrote: > We only cache deltas when it's smaller than a certain limit. This limit > defaults to 1000 but save its compressed length in a 64-bit field. > Shrink that field down to 16 bits, so you can only cache 65kb deltas. > Larger delt

[PATCH v7 08/13] pack-objects: shrink z_delta_size field in struct object_entry

2018-03-23 Thread Nguyễn Thái Ngọc Duy
We only cache deltas when it's smaller than a certain limit. This limit defaults to 1000 but save its compressed length in a 64-bit field. Shrink that field down to 16 bits, so you can only cache 65kb deltas. Larger deltas must be recomputed at when the pack is written down. Signed-off-by: Nguyễn