Re: [PATCH v7 01/10] Add support for -i/--interactive to git-clean

2013-05-13 Thread Jiang Xin
2013/5/13 Matthieu Moy : >> + /* Confirmation dialog */ >> + printf(_("Remove ([y]es/[n]o/[e]dit) ? ")); > > To be more consistent with "git add -p", this should use [] instead of > (), and have no space before "?". Will be replaced with: printf(_("Remove [y/n

Re: [PATCH v7 01/10] Add support for -i/--interactive to git-clean

2013-05-12 Thread Matthieu Moy
Jiang Xin writes: > + putchar('\n'); > + > + /* Display dels in "Would remove ..." format */ > + for_each_string_list_item(item, &del_list) { > + qname = quote_path_relative(item->string, -1, > &buf, *the_pre

Re: [PATCH v7 01/10] Add support for -i/--interactive to git-clean

2013-05-09 Thread Jiang Xin
2013/5/9 Junio C Hamano : >> @@ -15,9 +15,12 @@ >> #include "quote.h" >> >> static int force = -1; /* unset */ >> +static int interactive; >> +static struct string_list del_list = STRING_LIST_INIT_DUP; >> +static const char **the_prefix; > > Ehh, why? Next reroll will save relative paths in del_

Re: [PATCH v7 01/10] Add support for -i/--interactive to git-clean

2013-05-08 Thread Junio C Hamano
Jiang Xin writes: > Show what would be done and the user must confirm before actually > cleaning. In the confirmation dialog, the user has three choices: > > * y/yes: Start to do cleaning. > * n/no: Nothing will be deleted. > * e/edit: Exclude items from deletion using ignore patterns. > >

[PATCH v7 01/10] Add support for -i/--interactive to git-clean

2013-05-08 Thread Jiang Xin
Show what would be done and the user must confirm before actually cleaning. In the confirmation dialog, the user has three choices: * y/yes: Start to do cleaning. * n/no: Nothing will be deleted. * e/edit: Exclude items from deletion using ignore patterns. When the user chooses the edit mod