Re: [PATCH v7 0/4] recursive support for ls-files

2016-10-07 Thread Brandon Williams
On 10/07, Stefan Beller wrote: > On Fri, Oct 7, 2016 at 11:34 AM, Stefan Beller wrote: > > On Fri, Oct 7, 2016 at 11:18 AM, Brandon Williams wrote: > >> Few minor fixes pointed out Stefan > > > > The series itself looks good though. :) > > Thanks, > Stefan Thanks! And I'll keep that in mind fo

Re: [PATCH v7 0/4] recursive support for ls-files

2016-10-07 Thread Stefan Beller
On Fri, Oct 7, 2016 at 11:34 AM, Stefan Beller wrote: > On Fri, Oct 7, 2016 at 11:18 AM, Brandon Williams wrote: >> Few minor fixes pointed out Stefan > The series itself looks good though. :) Thanks, Stefan

Re: [PATCH v7 0/4] recursive support for ls-files

2016-10-07 Thread Stefan Beller
On Fri, Oct 7, 2016 at 11:18 AM, Brandon Williams wrote: > Few minor fixes pointed out Stefan Nit: This is not very informative, so you could provide an "interdiff" to the last patch, (see https://github.com/trast/tbdiff for a sophisticated tool, I usually do a git diff origin/sb/) That helps rev

[PATCH v7 0/4] recursive support for ls-files

2016-10-07 Thread Brandon Williams
Few minor fixes pointed out Stefan Brandon Williams (4): git: make super-prefix option ls-files: optionally recurse into submodules ls-files: pass through safe options for --recurse-submodules ls-files: add pathspec matching for submodules Documentation/git-ls-files.txt | 7 +-